Re: [PATCH 5/5] scsi: ufs: Ungate the clock synchronously

[Bart Van Assche <bvanassche@xxxxxxx>]

On 5/7/23 00:08, Avri Altman wrote:
> > -int ufshcd_hold(struct ufs_hba *hba, bool async)
> > +void ufshcd_hold(struct ufs_hba *hba)
> >   {
> How about switching to the block quiescing API as well - blk_mq_{un}quiesce_tagset,
> Instead of scsi_{un}block_requests?

Hi Avri,

Did you perhaps want to refer to blk_mq_freeze_queue()? 
ufshcd_scsi_block_requests() may be called from inside 
ufshcd_queuecommand(). Calling blk_mq_freeze_queue() from inside 
ufshcd_queuecommand() would cause a deadlock.

Thanks,

Bart.