On Mon, 17 Apr 2023 at 10:47, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote: > > On Sat, 8 Apr 2023 at 23:40, Abel Vesa <abel.vesa@xxxxxxxxxx> wrote: > > > > Now that there is a new dedicated ICE driver, drop the sdhci-msm ICE > > implementation and use the new ICE api provided by the Qualcomm soc > > driver ice. The platforms that already have ICE support will use the > > API as library since there will not be a devicetree node, but instead > > they have reg range. In this case, the of_qcom_ice_get will return an > > ICE instance created for the consumer's device. But if there are > > platforms that do not have ice reg in the consumer devicetree node > > and instead provide a dedicated ICE devicetree node, theof_qcom_ice_get > > will look up the device based on qcom,ice property and will get the ICE > > instance registered by the probe function of the ice driver. > > > > The ICE clock is now handle by the new driver. This is done by enabling > > it on the creation of the ICE instance and then enabling/disabling it on > > SDCC runtime resume/suspend. > > > > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx> > > Acked-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx> > > Bjorn, I think it should be easier if you pick this together with qcom > soc driver changes. I don't think there is any conflict with changes > in my mmc tree. > > Otherwise, I will just wait for the next release cycle. Okay, it looks like all dependent pieces made it into v6.4-rc1. So, applied for next, thanks! [...] Kind regards Uffe