On Mon, May 08, 2023 at 07:10:31AM -0700, Bart Van Assche wrote: > On 5/8/23 07:05, Benjamin Block wrote: > > On Wed, May 03, 2023 at 04:06:52PM -0700, Bart Van Assche wrote: > >> @@ -285,11 +290,22 @@ DECLARE_EVENT_CLASS(scsi_cmd_done_timeout_template, > >> __entry->prot_sglen = scsi_prot_sg_count(cmd); > >> __entry->prot_op = scsi_get_prot_op(cmd); > >> memcpy(__get_dynamic_array(cmnd), cmd->cmnd, cmd->cmd_len); > >> + if (cmd->sense_buffer && SCSI_SENSE_VALID(cmd) && > > > > Can't hurt to have these explicitly here, but these checks are also > > done by `scsi_command_normalize_sense()` AFAICT. > > Niklas requested these checks as a performance optimization. Oh okay, didn't remember that. Fair enough. -- Best Regards, Benjamin Block / Linux on IBM Z Kernel Development IBM Deutschland Research & Development GmbH / https://www.ibm.com/privacy Vors. Aufs.-R.: Gregor Pillen / Geschäftsführung: David Faller Sitz der Ges.: Böblingen / Registergericht: AmtsG Stuttgart, HRB 243294
