Re: [PATCH v2 2/5] scsi: core: Update a source code comment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 03, 2023 at 04:06:51PM -0700, Bart Van Assche wrote:
> The proc_name SCSI host template attribute is used for:
> - The name of the /proc directory if CONFIG_SCSI_PROC_FS=y.

But now you remove that case completely? It seems kinda strange to
bother touching the comment, but then only switching from one incomplete
form to an other?

> - The contents of the proc_name SCSI host sysfs attribute.
> 
> The current comment in include/scsi/scsi_host.h is not correct if
> CONFIG_SCSI_PROC_FS=n. Hence, change that comment.
> 
> Cc: Christoph Hellwig <hch@xxxxxx>
> Cc: Ming Lei <ming.lei@xxxxxxxxxx>
> Cc: Hannes Reinecke <hare@xxxxxxx>
> Cc: John Garry <john.g.garry@xxxxxxxxxx>
> Cc: Mike Christie <michael.christie@xxxxxxxxxx>
> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
> ---
>  include/scsi/scsi_host.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h
> index 0f29799efa02..18632adca17e 100644
> --- a/include/scsi/scsi_host.h
> +++ b/include/scsi/scsi_host.h
> @@ -365,7 +365,7 @@ struct scsi_host_template {
>  
>  
>  	/*
> -	 * Name of proc directory
> +	 * Name reported via the proc_name SCSI host sysfs attribute.
>  	 */
>  	const char *proc_name;
>  

-- 
Best Regards, Benjamin Block        /        Linux on IBM Z Kernel Development
IBM Deutschland Research & Development GmbH    /   https://www.ibm.com/privacy
Vors. Aufs.-R.: Gregor Pillen         /         Geschäftsführung: David Faller
Sitz der Ges.: Böblingen     /    Registergericht: AmtsG Stuttgart, HRB 243294



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux