On Thu, May 04, 2023 at 08:52:26AM +0000, Benjamin Block wrote: > On Wed, May 03, 2023 at 10:25:10AM -0400, Alan Stern wrote: > > I think the best answer is to accept the patch that started this email > > thread, perhaps with a minor change. The driver can easily abort the > > currently running command (if any) on its own before starting a reset. > > I don't think we would add an other layer of aborts in front of > device/LUN reset for all SCSI targets. That's just overkill for - it > seems - everything but USB storage, and would slow down error recovery > considerable in some cases. This is consistent with what I wrote. The patch that started this email thread made a change to the usb-storage driver; it did not touch any part of the SCSI core. Maxime, would you like to submit a revised version of your patch? The key difference is that it should abort the currently executing command (if there is one), regardless of whether the srb value matches. Alan Stern > If this is supposed to be done in the SCSI ML, it would have to be a > quirk/option IMO. > > -- > Best Regards, Benjamin Block / Linux on IBM Z Kernel Development > IBM Deutschland Research & Development GmbH / https://www.ibm.com/privacy > Vors. Aufs.-R.: Gregor Pillen / Geschäftsführung: David Faller > Sitz der Ges.: Böblingen / Registergericht: AmtsG Stuttgart, HRB 243294
