Re: [PATCH 4/4] scsi: Trace SCSI sense data

[Bart Van Assche <bvanassche@xxxxxxx>]

On 5/2/23 02:52, Niklas Cassel wrote:
> i.e., something like:
> 	if (cmd->sense_buffer && SCSI_SENSE_VALID(cmd) &&
> 	    scsi_command_normalize_sense(cmd, &sshdr)) {
>
> instead of cmd->result & 0xff.

Hmm ... doesn't the SCSI_SENSE_VALID() check above duplicate the
scsi_sense_valid() check inside scsi_command_normalize_sense()?

Thanks,

Bart.