Hi Po-Wen, Po-Wen Kao <powen.kao@xxxxxxxxxxxx> 於 2023年4月24日 週一 下午10:13寫道： > > Transfer command descriptor is allocated in ufshcd_memory_alloc() > and referenced by transfer request descriptor with stride size > sizeof_utp_transfer_cmd_desc() > instead of > sizeof(struct utp_transfer_cmd_desc). > > Consequently, computing tag by address offset should also refer to the > same stride. > > Signed-off-by: Po-Wen Kao <powen.kao@xxxxxxxxxxxx> > Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx> > Reviewed-by: Manivannan Sadhasivam <mani@xxxxxxxxxx> > Reviewed-by: Stanley Chu <stanley.chu@xxxxxxxxxxxx> > Reviewed-by: Ziqi Chen <quic_ziqichen@xxxxxxxxxxx> > --- > drivers/ufs/core/ufs-mcq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c > index 31df052fbc41..3a27fa4b0024 100644 > --- a/drivers/ufs/core/ufs-mcq.c > +++ b/drivers/ufs/core/ufs-mcq.c > @@ -265,7 +265,7 @@ static int ufshcd_mcq_get_tag(struct ufs_hba *hba, > addr = (le64_to_cpu(cqe->command_desc_base_addr) & CQE_UCD_BA) - > hba->ucdl_dma_addr; > > - return div_u64(addr, sizeof(struct utp_transfer_cmd_desc)); > + return div_u64(addr, sizeof_utp_transfer_cmd_desc(hba)); Would you also need to consider the ufshcd_release_sdb_queue() case? Thanks. Stanley Chu
