Hi Bart, kernel test robot noticed the following build errors: [auto build test ERROR on mkp-scsi/for-next] [also build test ERROR on jejb-scsi/for-next linus/master v6.3 next-20230425] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Bart-Van-Assche/scsi-core-Use-min-instead-of-open-coding-it/20230426-073743 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next patch link: https://lore.kernel.org/r/20230425233446.1231000-4-bvanassche%40acm.org patch subject: [PATCH 3/4] scsi: Only kick the requeue list if necessary config: i386-randconfig-a013 (https://download.01.org/0day-ci/archive/20230426/202304261310.YvjIbyb4-lkp@xxxxxxxxx/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/1f35bc98f5c39b963f1cbb31159a1e1395dda276 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Bart-Van-Assche/scsi-core-Use-min-instead-of-open-coding-it/20230426-073743 git checkout 1f35bc98f5c39b963f1cbb31159a1e1395dda276 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/scsi/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202304261310.YvjIbyb4-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): >> drivers/scsi/scsi_lib.c:509:28: error: use of undeclared identifier 'cmd' if (scsi_host_in_recovery(cmd->device->host)) ^ 1 error generated. vim +/cmd +509 drivers/scsi/scsi_lib.c 506 507 static void scsi_run_queue_async(struct scsi_device *sdev) 508 { > 509 if (scsi_host_in_recovery(cmd->device->host)) 510 return; 511 512 if (scsi_target(sdev)->single_lun || 513 !list_empty(&sdev->host->starved_list)) { 514 kblockd_schedule_work(&sdev->requeue_work); 515 } else { 516 /* 517 * smp_mb() present in sbitmap_queue_clear() or implied in 518 * .end_io is for ordering writing .device_busy in 519 * scsi_device_unbusy() and reading sdev->restarts. 520 */ 521 int old = atomic_read(&sdev->restarts); 522 523 /* 524 * ->restarts has to be kept as non-zero if new budget 525 * contention occurs. 526 * 527 * No need to run queue when either another re-run 528 * queue wins in updating ->restarts or a new budget 529 * contention occurs. 530 */ 531 if (old && atomic_cmpxchg(&sdev->restarts, old, 0) == old) 532 blk_mq_run_hw_queues(sdev->request_queue, true); 533 } 534 } 535 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
