On 4/18/23 07:13, Adrian Hunter wrote:
On 18/04/23 17:06, Bart Van Assche wrote:
On 4/18/23 06:45, Adrian Hunter wrote:
On 18/04/23 02:06, Bart Van Assche wrote:
Now that sd_shutdown() fails future I/O the code for quiescing LUNs in
ufshcd_wl_shutdown() is superfluous. Remove the code for quiescing LUNs.
Also remove the ufshcd_rpm_get_sync() call because it is not necessary
to resume a UFS device before submitting a START STOP UNIT command.
What about the host controller hba->dev?
The above question is not clear to me. Please elaborate.
Does hba->dev need to be runtime resumed?
Hi Adrian,
I don't think so. Shutdown callback functions are expected to quiesce
hardware activity. To me runtime resuming a device seems to contradict
the goal of quiescing hardware activity.
Thanks,
Bart.