On 4/13/23 16:35, John Garry wrote: > On 12/04/2023 18:40, Brian King wrote: >> Linux SATA support in ipr has always been limited to SATA DVDs. The last >> systems that had the option of including a SATA DVD was Power 8, >> which have been withdrawn for sometime now, so this support can >> be removed. >> >> Signed-off-by: Brian King<brking@xxxxxxxxxxxxxxxxxx> >> --- > > Thanks, > > Reviewed-by: John Garry <john.g.garry@xxxxxxxxxx> > >> -#endif >> .queuecommand = ipr_queuecommand, >> - .dma_need_drain = ata_scsi_dma_need_drain, > > This would only be used by libsas now - maybe we should relocate it > there (from libata), but prob better not. Given that with this patch, all ATA drivers will use ->error_handler, there are lots of cleanups we can do. Let's work on that once this patch is queued !