On 4/11/23 16:23, Christoph Hellwig wrote: > On Tue, Apr 11, 2023 at 04:09:34PM +0900, Damien Le Moal wrote: >> But yes, I guess we could just unconditionally enable CDL for ATA on device scan >> to be on par with scsi, which has CDL always enabled. > > I'd prefer that. With a module option to not enable it just to be > safe. Then it may be better to move the cdl_enable attribute store definition for ATA devices to libata. That would be less messy that way. Let me see if that can be done cleanly.