On Fri, Apr 07, 2023 at 01:50:23PM +0300, Abel Vesa wrote: > As both SDCC and UFS drivers use the ICE with duplicated implementation, > while none of the currently supported platforms make use concomitantly > of the same ICE IP block instance, the new SM8550 allows both UFS and > SDCC to do so. In order to support such scenario, there is a need for > a unified implementation and a devicetree node to be shared between > both types of storage devices. So lets drop the duplicate implementation > of the ICE from both SDCC and UFS and make it a dedicated (soc) driver. > > For now, only SM8550 has been added to support the new approach. This > also involves adding support for HW version 4.x. > I picked the ICE driver and pushed it out to make it possible to pick up the mmc and ufs patches independently. https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git tags/20230407105029.2274111-4-abel.vesa@xxxxxxxxxx Regards, Bjorn > The v5 is here: > https://lore.kernel.org/all/20230403200530.2103099-1-abel.vesa@xxxxxxxxxx/ > > Changes since v5: > * See each individual patch for changelogs. > > Changes since v4: > * dropped the SDHCI dt-bindings patch as it will be added along > with the first use of qcom,ice property from an SDHCI DT node > > Abel Vesa (6): > dt-bindings: crypto: Add Qualcomm Inline Crypto Engine > dt-bindings: ufs: qcom: Add ICE phandle > soc: qcom: Make the Qualcomm UFS/SDCC ICE a dedicated driver > scsi: ufs: ufs-qcom: Switch to the new ICE API > mmc: sdhci-msm: Switch to the new ICE API > arm64: dts: qcom: sm8550: Add the Inline Crypto Engine node > > .../crypto/qcom,inline-crypto-engine.yaml | 42 ++ > .../devicetree/bindings/ufs/qcom,ufs.yaml | 26 ++ > arch/arm64/boot/dts/qcom/sm8550.dtsi | 9 + > drivers/mmc/host/Kconfig | 2 +- > drivers/mmc/host/sdhci-msm.c | 223 +++-------- > drivers/soc/qcom/Kconfig | 4 + > drivers/soc/qcom/Makefile | 1 + > drivers/soc/qcom/ice.c | 366 ++++++++++++++++++ > drivers/ufs/host/Kconfig | 2 +- > drivers/ufs/host/Makefile | 4 +- > drivers/ufs/host/ufs-qcom-ice.c | 244 ------------ > drivers/ufs/host/ufs-qcom.c | 99 ++++- > drivers/ufs/host/ufs-qcom.h | 32 +- > include/soc/qcom/ice.h | 37 ++ > 14 files changed, 637 insertions(+), 454 deletions(-) > create mode 100644 Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml > create mode 100644 drivers/soc/qcom/ice.c > delete mode 100644 drivers/ufs/host/ufs-qcom-ice.c > create mode 100644 include/soc/qcom/ice.h > > -- > 2.34.1 >
