On 06/04/2023 08:46, Harshit Mogalapalli wrote:
Smatch reports: drivers/scsi/scsi_debug.c:6996 scsi_debug_init() warn: missing error code 'ret' Although it is unlikely that KMEM_CACHE might fail, but if it does then ret might be zero. So to fix this explicitly mark ret as "-ENOMEM" and then goto driver_unreg. Fixes: 1107c7b24ee3 ("scsi: scsi_debug: Dynamically allocate sdebug_queued_cmd") Signed-off-by: Harshit Mogalapalli<harshit.m.mogalapalli@xxxxxxxxxx> ---
thanks Reviewed-by: John Garry <john.g.garry@xxxxxxxxxx>