Hi Damien,
On 2023/4/2 12:58, Damien Le Moal wrote:
On 4/1/23 17:15, Jason Yan wrote:
In sas_check_eeds() there is an empty branch. We can reverse the
test expression and then remove the empty branch. Also the the test
expression is a little bit complex so it deserves an individual
function. And make the continuing prototype lines indented after
the opening parenthesis to follow the standard coding style.
Signed-off-by: Jason Yan <yanaijie@xxxxxxxxxx>
---
drivers/scsi/libsas/sas_expander.c | 38 ++++++++++++++----------------
1 file changed, 18 insertions(+), 20 deletions(-)
diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_expander.c
index dc670304f181..048a931d856a 100644
--- a/drivers/scsi/libsas/sas_expander.c
+++ b/drivers/scsi/libsas/sas_expander.c
@@ -1198,37 +1198,35 @@ static void sas_print_parent_topology_bug(struct domain_device *child,
sas_route_char(child, child_phy));
}
+static bool sas_eeds_valid(struct domain_device *parent, struct domain_device *child)
+{
+ struct sas_discovery *disc = &parent->port->disc;
Missing blank line after declaration.
OK.
+ return (((SAS_ADDR(disc->eeds_a) == SAS_ADDR(parent->sas_addr)) ||
+ (SAS_ADDR(disc->eeds_a) == SAS_ADDR(child->sas_addr))) &&
+ ((SAS_ADDR(disc->eeds_b) == SAS_ADDR(parent->sas_addr)) ||
+ (SAS_ADDR(disc->eeds_b) == SAS_ADDR(child->sas_addr))));
Drop the inner-most and outter-most parenthesis.
No problem.
Thanks,
Jason
