On Wed, 01 Aug 2007 17:27:39 +0900
Tejun Heo <htejun@xxxxxxxxx> wrote:
> Kristen Carlson Accardi wrote:
<snippy>
> Is it safe to use ALPM on a device which only claims to support DIPM?
Yes - I doubled checked this with the AHCI people - and of course you
have Edvin's testing to prove it does fine.
> I think this should be ATA_HORKAGE_IPM.
OK - I changed it.
> > @@ -321,6 +321,8 @@ struct ata_taskfile {
> > ((u64) (id)[(n) + 0]) )
> >
> > #define ata_id_cdb_intr(id) (((id)[0] & 0x60) == 0x20)
> > +#define ata_id_has_hipm(id) ((id)[76] & (1 << 9))
> > +#define ata_id_has_dipm(id) ((id)[78] & (1 << 3))
>
> We probably need !0xffff test here.
Thanks, I fixed that too.
As far as moving the enable/disable_pm calls to EH - can you take
a look at the other patch I sent which implements the shost_attrs
to see if I still need to do this? I really don't know much about
the EH stuff - can you explain why we need to use it to set the
link pm?
thanks for your review,
Kristen
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
