On Tue, Mar 28, 2023 at 3:00 PM John Garry <john.g.garry@xxxxxxxxxx> wrote: > > On 28/03/2023 03:53, Yi Zhang wrote: > > Hello > > > > I found blktests scsi/004 failed[2] on the latest linux-scsi/for-next, > > bisecting shows it was introduced from[1], pls help check it and let > > me know if you need any testing for it, thanks. > > Thanks for the report. I have sent a fix in > https://lore.kernel.org/linux-scsi/20230327074310.1862889-1-john.g.garry@xxxxxxxxxx/T/#ma8b4e8856df99139ae4879fa0f49befbf69f1a57 > Yeah, the issue was fixed by the patch, thanks for the update. > Please check it. > > > > > [1] > > 151f0ec9ddb5 (HEAD) scsi: scsi_debug: Drop sdebug_dev_info.num_in_q > > [2] > > + ./check scsi/004 > > scsi/004 (ensure repeated TASK SET FULL results in EIO on timing out > > command) [failed] > > runtime 1.889s ... 1.851s > > --- tests/scsi/004.out 2023-03-27 02:51:16.755636763 -0400 > > +++ /root/blktests/results/nodev/scsi/004.out.bad 2023-03-27 > > 22:49:53.511526901 -0400 > > @@ -1,3 +1,2 @@ > > Running scsi/004 > > -Input/output error > > Test complete > > dmesg: > > [ 268.314709] run blktests scsi/004 at 2023-03-27 22:49:51 > > [ 268.325391] scsi_debug:sdebug_driver_probe: scsi_debug: trim > > poll_queues to 0. poll_q/nr_hw = (0/1) > > [ 268.325398] scsi host0: scsi_debug: version 0191 [20210520] > > dev_size_mb=8, opts=0x0, submit_queues=1, statistics=1 > > [ 268.325575] scsi 0:0:0:0: Direct-Access Linux scsi_debug > > 0191 PQ: 0 ANSI: 7 > > [ 268.325693] sd 0:0:0:0: Attached scsi generic sg0 type 0 > > [ 268.325775] sd 0:0:0:0: Power-on or device reset occurred > > [ 268.345884] sd 0:0:0:0: [sda] 16384 512-byte logical blocks: (8.39 > > MB/8.00 MiB) > > [ 268.355905] sd 0:0:0:0: [sda] Write Protect is off > > [ 268.355909] sd 0:0:0:0: [sda] Mode Sense: 73 00 10 08 > > [ 268.375943] sd 0:0:0:0: [sda] Write cache: enabled, read cache: > > enabled, supports DPO and FUA > > [ 268.406011] sd 0:0:0:0: [sda] Preferred minimum I/O size 512 bytes > > [ 268.406016] sd 0:0:0:0: [sda] Optimal transfer size 524288 bytes > > [ 268.537442] sd 0:0:0:0: [sda] Attached SCSI disk > > [ 270.067115] sd 0:0:0:0: [sda] Synchronizing SCSI cache > > > > > -- Best Regards, Yi Zhang
