On 23/03/2023 14:13, Neil Armstrong wrote: > On 23/03/2023 11:47, Krzysztof Kozlowski wrote: >> On 23/03/2023 11:25, Neil Armstrong wrote: >>> Fixes the following DT bindings check error: >>> codec@33f0000: clocks: [[137, 57, 1], [137, 102, 1], [137, 103, 1], [137, 70, 1]] is too long >>> codec@33f0000: clock-names: 'oneOf' conditional failed, one must be fixed: >>> ['mclk', 'macro', 'dcodec', 'npl'] is too long >>> >>> The implementation was checked and this npl clock isn't used for the VA macro. >>> >> >> This does not look correct. DTS looks good, you miss some patches in >> your tree. > > I'm based on today's linux-next, Which is unfortunately not enough. Several things were fixed/added/changed and are pending. I brought the topic of pending branch few times on IRC for that reason. > while the other lpass macros uses the npl clock, > the lpass vamacro bindings doesn't document the npl clock. > > And I found no fixes whatsover to add the npl clock to bindings. Really? lore finds it easily: https://lore.kernel.org/all/20221118071849.25506-2-srinivas.kandagatla@xxxxxxxxxx/ Best regards, Krzysztof
