Re: [RFC PATCH v3 1/5] ufs: mcq: Add supporting functions for mcq abort

["Bao D. Nguyen" <quic_nguyenb@xxxxxxxxxxx>]

On 3/23/2023 3:07 AM, John Garry wrote:
> On 23/03/2023 09:53, Bao D. Nguyen wrote:
> > +static int ufshcd_mcq_poll_register(void __iomem *reg, u32 mask,
> > +            u32 val, unsigned long timeout_ms)
> > +{
> > +    unsigned long timeout = jiffies + msecs_to_jiffies(timeout_ms);
> > +    int err = 0;
> > +
> > +    /* ignore bits that we don't intend to wait on */
> > +    val = val & mask;
> > +
> > +    while ((readl(reg) & mask) != val) {
> > +        usleep_range(10, 50);
> > +        if (time_after(jiffies, timeout)) {
> > +            err = -ETIMEDOUT;
> > +            break;
> > +        }
>
> This looks just like readl_poll_timeout()
I will make the change in the next revision. Thanks John.
> > +    }
> > +
> > +    return err;
> > +}