Re: [PATCH RESEND v2 09/11] scsi: scsi_debug: Drop sdebug_dev_info.num_in_q

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 20/03/2023 11:41, John Garry wrote:
scsi/004 (ensure repeated TASK SET FULL results in EIO on timing out command) [failed]
     runtime    ...  1.467s
     --- tests/scsi/004.out    2023-02-28 16:52:49.000000000 +0000
     +++ /lkp/benchmarks/blktests/results/nodev/scsi/004.out.bad 2023-03-18 00:19:00.232079954 +0000
     @@ -1,3 +1,2 @@
      Running scsi/004
     -Input/output error
      Test complete


I'll check this now.

This should fix it:

--- a/drivers/scsi/scsi_debug.c
+++ b/drivers/scsi/scsi_debug.c
@@ -5580,7 +5580,7 @@ static int schedule_resp(struct scsi_cmnd *cmnd, struct sdebug_dev_info *devip,
                int num_in_q = scsi_device_busy(sdp);
                int qdepth = cmnd->device->queue_depth;

-               if ((num_in_q == (qdepth - 1)) &&
+               if ((num_in_q == qdepth) &&
                    (atomic_inc_return(&sdebug_a_tsf) >=


I'll send that change in my other scsi_debug series after I test further.





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux