Re: [PATCH -next] scsi: scsi_dh_alua: fix memleak for 'qdata' in alua_activate()

[Bart Van Assche <bvanassche@xxxxxxx>]

On 3/14/23 23:21, Yu Kuai wrote:
> diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c
> index 362fa631f39b..a226dc1b65d7 100644
> --- a/drivers/scsi/device_handler/scsi_dh_alua.c
> +++ b/drivers/scsi/device_handler/scsi_dh_alua.c
> @@ -1145,10 +1145,12 @@ static int alua_activate(struct scsi_device *sdev,
>   	rcu_read_unlock();
>   	mutex_unlock(&h->init_mutex);
>   
> -	if (alua_rtpg_queue(pg, sdev, qdata, true))
> +	if (alua_rtpg_queue(pg, sdev, qdata, true)) {
>   		fn = NULL;
> -	else
> +	} else {
> +		kfree(qdata);
>   		err = SCSI_DH_DEV_OFFLINED;
> +	}
>   	kref_put(&pg->kref, release_port_group);
>   out:
>   	if (fn)

Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>