On 3/13/23 20:29, Powen Kao (高伯文) wrote:
We did not implement ESI at hardware level but per queue hw interrupt. Without disabling MCQ_CQ_EVENT_STATUS, there will be two interrupts, CQES (traditional interrupt) and CQ Tail Entry Push Interrupt (per queue hw interrupt), raised on a signle command arrival. I wouldn't consider it as a bug, but different interrupt design.
I do not agree with adding the ufshcd_disable_intr() call in the MediaTek driver. Please move this call to UFS host controller driver core and add a quirk since the behavior described above does not comply with the UFSHCI 4.0 standard. See also include/ufs/ufs_quirks.h.
Thanks, Bart.
