Re: [PATCH 01/81] scsi: qla2xxx: Refer directly to the qla2xxx_driver_template

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/03/2023 18:42, Bart Van Assche wrote:
On 3/6/23 05:10, John Garry wrote:
Apart from that, I will say that I haven't studied the driver in detail, but my impression is that we should just set this flag per-shost in base_vha->host.active_mode, and not the host template supported_mode member. Indeed, we don't even seem to be making this driver scsi_host_template as const in this series, which I thought was the aim (and I assume because of this).

This patch is necessary because this patch prevents to declare the 'hostt' member of struct Scsi_Host const.

ok, sure, but I am just saying that that the pre-existing code looks suspicious. However, as I mentioned before, things like this (modifying the host template) could be improved later by someone.

Thanks,
John



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux