Hello Ranjan Kumar,
The patch 2c6ebf96dfdf: "scsi: mpt3sas: Reload SBR without rebooting
HBA" from Feb 8, 2023, leads to the following Smatch static checker
warning:
drivers/scsi/mpt3sas/mpt3sas_base.c:7968 mpt3sas_base_unlock_and_get_host_diagnostic() warn: inconsistent indenting
drivers/scsi/mpt3sas/mpt3sas_ctl.c:2576 _ctl_enable_diag_sbr_reload() warn: inconsistent indenting
drivers/scsi/mpi3mr/mpi3mr_transport.c:2365 mpi3mr_report_tgtdev_to_sas_transport() warn: inconsistent indenting
drivers/scsi/mpt3sas/mpt3sas_base.c
7931 int
7932 mpt3sas_base_unlock_and_get_host_diagnostic(struct MPT3SAS_ADAPTER *ioc,
7933 u32 *host_diagnostic)
7934 {
7935 u32 count;
7936 *host_diagnostic = 0;
7937 count = 0;
7938
7939 do {
7940 /* Write magic sequence to WriteSequence register
7941 * Loop until in diagnostic mode
7942 */
7943 drsprintk(ioc, ioc_info(ioc, "write magic sequence\n"));
7944 writel(MPI2_WRSEQ_FLUSH_KEY_VALUE, &ioc->chip->WriteSequence);
7945 writel(MPI2_WRSEQ_1ST_KEY_VALUE, &ioc->chip->WriteSequence);
7946 writel(MPI2_WRSEQ_2ND_KEY_VALUE, &ioc->chip->WriteSequence);
7947 writel(MPI2_WRSEQ_3RD_KEY_VALUE, &ioc->chip->WriteSequence);
7948 writel(MPI2_WRSEQ_4TH_KEY_VALUE, &ioc->chip->WriteSequence);
7949 writel(MPI2_WRSEQ_5TH_KEY_VALUE, &ioc->chip->WriteSequence);
7950 writel(MPI2_WRSEQ_6TH_KEY_VALUE, &ioc->chip->WriteSequence);
7951
7952 /* wait 100 msec */
7953 msleep(100);
7954
7955 if (count++ > 20) {
7956 ioc_info(ioc,
7957 "Stop writing magic sequence after 20 retries\n");
7958 _base_dump_reg_set(ioc);
7959 return -EFAULT;
7960 }
7961
7962 *host_diagnostic = ioc->base_readl(&ioc->chip->HostDiagnostic);
7963 drsprintk(ioc,
7964 ioc_info(ioc, "wrote magic sequence: count(%d), host_diagnostic(0x%08x)\n",
7965 count, *host_diagnostic));
7966
7967 } while ((*host_diagnostic & MPI2_DIAG_DIAG_WRITE_ENABLE) == 0);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Indented too far.
--> 7968 return 0;
7969 }
regards,
dan carpenter
