Re: [RFC PATCH v1 2/4] ufs: mcq: Add supporting functions for mcq abort

To: "Bao D. Nguyen" <quic_nguyenb@xxxxxxxxxxx>, quic_asutoshd@xxxxxxxxxxx, quic_cang@xxxxxxxxxxx, mani@xxxxxxxxxx, stanley.chu@xxxxxxxxxxxx, adrian.hunter@xxxxxxxxx, beanhuo@xxxxxxxxxx, avri.altman@xxxxxxx, martin.petersen@xxxxxxxxxx
Subject: Re: [RFC PATCH v1 2/4] ufs: mcq: Add supporting functions for mcq abort
From: Bart Van Assche <bvanassche@xxxxxxx>
Date: Wed, 8 Mar 2023 15:23:48 -0800
Cc: linux-scsi@xxxxxxxxxxxxxxx, Alim Akhtar <alim.akhtar@xxxxxxxxxxx>, "James E.J. Bottomley" <jejb@xxxxxxxxxxxxx>, Arthur Simchaev <Arthur.Simchaev@xxxxxxx>, open list <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <f4f5eef5-c0d4-0de6-71df-c70f0ce4064a@quicinc.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1

On 3/8/23 14:27, Bao D. Nguyen wrote:

This is to give us the flexibility to override this parameter in thedownstream driver if needed.

Please do not introduce functionality before it is needed. See alsohttps://en.wikipedia.org/wiki/You_aren%27t_gonna_need_it.


Thanks,

Bart.

Follow-Ups:
- Re: [RFC PATCH v1 2/4] ufs: mcq: Add supporting functions for mcq abort
  - From: Bao D. Nguyen

References:
- [RFC PATCH v1 0/4] ufs: core: mcq: Add ufshcd_abort() support in MCQ mode
  - From: Bao D. Nguyen
- [RFC PATCH v1 2/4] ufs: mcq: Add supporting functions for mcq abort
  - From: Bao D. Nguyen
- Re: [RFC PATCH v1 2/4] ufs: mcq: Add supporting functions for mcq abort
  - From: Bart Van Assche
- Re: [RFC PATCH v1 2/4] ufs: mcq: Add supporting functions for mcq abort
  - From: Bao D. Nguyen