On Tue, 2007-07-31 at 10:00 -0600, Matthew Wilcox wrote: > On Tue, Jul 31, 2007 at 10:05:50AM -0500, James Bottomley wrote: > > I agree the NCR_700_release should be the last method called. However, > > the NCR_700_detect() API calls scsi_host_alloc/scsi_add_host() ... the > > API will be horribly assymetric (and thus prone to misuse) with regard > > to the host lifetime management if the NCR_700_release() method doesn't > > tidy up the host. > > > > I can go either way, but either the alloc/add has to come out of the > > detect method or the put has to go into the release method. > > It's already asymmetric -- scsi_remove_host is called by the front > end driver, and that's the opposite to scsi_add_host, which is done in > NCR_700_detect. In many ways that's paired with the external scsi_scan_host() ... although they're not true pairs in the model. I don't really see a reason to separate NCR_700_release() and scsi_host_put() unless there's something I'm missing? James - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
