On 04.03.23 16:21, Bart Van Assche wrote: >> Sure, the drive will fail this request, so the end result is the same. But what >> is the point of issuing such unaligned request that we know will fail ? The >> error message also make it easier to debug as it clarifies that this is not a >> write pointer violation. So while this change is not critical, it does have >> merits in my opinion. > > I think that there are other ways to debug software that triggers an > unaligned write, e.g. ftrace. Yeah but in order to do that, you have to restart your workload (that could potentially run days to trigger), start ftrace, yada yada. So either that or have a message in dmesg, that your log collector can aggregate and is easy to parse. It's not so much about duplication, but about user friendliness. Johannes
