Re: [PATCH] dpt_i2o: convert to SCSI hotplug model

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 30, 2007 at 03:19:18PM -0600, Matthew Wilcox wrote:
> dpt_i2o: Convert to new SCSI driver model
> 
>  - Delete refereces to HOSTS_C
>  - Switch to module_init/module_exit instead of detect/release
>  - Don't pass around the host template and rename it to adpt_template
>  - Switch from scsi_register/scsi_unregister to scsi_host_alloc,
>    scsi_add_host, scsi_scan_host and scsi_host_put.

Looks fine to me except that I'd prefer to see adpt_detect merged into
adpt_init even if that means moving some code around and the cleanup
in the init path might better be just opencoded than re-using adpt_exit
especiall if that one's going to get a little more complicated later on.

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux