Hi, On Sun, 29 Jul 2007, Matthias Kaehlcke wrote: > The OnStream SCSI Tape driver uses a semaphore as mutex. Use the mutex > API instead of the (binary) semaphore. > > Signed-off-by: Matthias Kaehlcke <matthias.kaehlcke@xxxxxxxxx> > [...] > @@ -3298,7 +3298,7 @@ static ssize_t osst_write(struct file * filp, const char __user * buf, size_t co > char * name = tape_name(STp); > > > - if (down_interruptible(&STp->lock)) > + if (mutex_lock_interruptible(&STp->lock)) > return (-ERESTARTSYS); The () after return existed in the code already, but you could've felt free to remove them :-) > @@ -3619,7 +3619,7 @@ static ssize_t osst_read(struct file * filp, char __user * buf, size_t count, lo > char * name = tape_name(STp); > > > - if (down_interruptible(&STp->lock)) > + if (mutex_lock_interruptible(&STp->lock)) > return (-ERESTARTSYS); Same here. Reviewed-by: Satyam Sharma <satyam@xxxxxxxxxxxxx> - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
