Re: [PATCH] scsi: dc395x: Replace arithmetic addition by bitwise OR

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Deepak R Varma <drv@xxxxxxxxx>, Ali Akcaagac <aliakc@xxxxxx>, Jamie Lenehan <lenehan@xxxxxxxxxxx>, "James E.J. Bottomley" <jejb@xxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, dc395x@xxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
Subject: Re: [PATCH] scsi: dc395x: Replace arithmetic addition by bitwise OR
From: Oliver Neukum <oneukum@xxxxxxxx>
Date: Wed, 8 Feb 2023 10:26:58 +0100
Cc: Saurabh Singh Sengar <ssengar@xxxxxxxxxxxxx>, Praveen Kumar <kumarpraveen@xxxxxxxxxxxxxxxxxxx>
In-reply-to: <Y+IQoG3aYdTfMStu@ubun2204.myguest.virtualbox.org>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1


On 07.02.23 09:49, Deepak R Varma wrote:

When adding two bit-field mask values, an OR operation offers higher
performance over an arithmetic operation.


Hi,

I am sorry, but this change log makes no sense. These are constants.
The compiler turns that into one value in any case.
If you do a clean up, say so.

	Regards
		Oliver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

References:
- [PATCH] scsi: dc395x: Replace arithmetic addition by bitwise OR
  - From: Deepak R Varma

Prev by Date: [PATCH] scsi: ips: clean up some inconsistent indenting
Next by Date: [PATCH 1/2] mpt3sas: Reload SBR without rebooting HBA
Previous by thread: Re: [PATCH] scsi: dc395x: Replace arithmetic addition by bitwise OR
Next by thread: IO error on DIF/DIX supported array
Index(es):
- Date
- Thread

[Index of Archives] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Samba] [Device Mapper]

Powered by Linux