On Tue, 2023-02-07 at 16:51 +0530, Deepak R Varma wrote: > When adding two bit-field mask values, an OR operation offers higher > performance over an arithmetic operation. So, convert such additions > to an OR based expressions. Issue identified using orplus.cocci > semantic patch script. No it doesn't, at least not for constants, which is the entirety of this patch: the compiler can find the value at compile time, so the whole lot becomes a load immediate of a single value. Whether the compiler sees OR or + is immaterial to the compile time computation. Perhaps Coccinelle should be fixed not to complain about this case? James
