From: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>
Subject: RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg
Date: Sun, 29 Jul 2007 14:07:01 +0900
> From: "Moore, Eric" <Eric.Moore@xxxxxxx>
> Subject: RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg
> Date: Fri, 27 Jul 2007 17:24:19 -0600
>
> > On Thursday, July 26, 2007 6:44 PM, FUJITA Tomonori wrote:
> > >
> > > Does this work for you? Sorry, I'm not at the lab now and can't test
> > > it. But I can do next week.
> > >
> > > I also updated bsg's smp_rep_manufacturer to print the mpi's
> > > replay. You can get it from the git tree.
> > >
> >
> > yes this will work, and I pulled the updated sgv4, and saw your
> > inclusion of mptsas.h.
>
> I confirmed that this patch sends mpi's unique reply back to user
> space.
>
> When I send a wrong smp frame, I got:
>
> nice:/home/fujita# ./sgv4-tools/smp_rep_manufacturer /sys/class/bsg/sas_host0
> IOCStatus=0x1 IOCLogInfo=0x0 SASStatus=0x2
> expected SMP frame response type, got=0x10
>
>
> Eric, can I get your ACK on this patch?
One comment on the the patch:
+ if (!(ioc->sas_mgmt.status & MPT_IOCTL_STATUS_COMMAND_GOOD)) {
+ printk(KERN_ERR "%s: smp response invalid!\n", __FUNCTION__);
+ ret = -ENXIO;
+ }
We don't need this part since user-space can get mpt's reply, I think.
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
