Re: [PATCH] scsi: libsas: Add missing check for dma_map_single

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jiasheng,

This patch looks good to me, but can you change your subject to "scsi: aic94xx: Add missing check for dma_map_single" since this is not in libsas code.

Thanks,
Jason

On 2022/12/28 12:24, Jiasheng Jiang wrote:
Add check for dma_map_single and return error if it fails in order
to avoid invalid dma address.

Fixes: 2908d778ab3e ("[SCSI] aic94xx: new driver")
Signed-off-by: Jiasheng Jiang <jiasheng@xxxxxxxxxxx>
---
  drivers/scsi/aic94xx/aic94xx_task.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/drivers/scsi/aic94xx/aic94xx_task.c b/drivers/scsi/aic94xx/aic94xx_task.c
index ed119a3f6f2e..7f0208300110 100644
--- a/drivers/scsi/aic94xx/aic94xx_task.c
+++ b/drivers/scsi/aic94xx/aic94xx_task.c
@@ -50,6 +50,9 @@ static int asd_map_scatterlist(struct sas_task *task,
  		dma_addr_t dma = dma_map_single(&asd_ha->pcidev->dev, p,
  						task->total_xfer_len,
  						task->data_dir);
+		if (dma_mapping_error(&asd_ha->pcidev->dev, dma))
+			return -ENOMEM;
+
  		sg_arr[0].bus_addr = cpu_to_le64((u64)dma);
  		sg_arr[0].size = cpu_to_le32(task->total_xfer_len);
  		sg_arr[0].flags |= ASD_SG_EL_LIST_EOL;




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux