On 2023-01-17 13:35:54 +0300, Alexey Khoroshilov wrote: >>>> Fixes: b705690d8d16f708 ("[SCSI] hpsa: combine >>>> hpsa_scsi_detect and hpsa_register_scsi") >>> That seems incorrect to me. Shouldn't the Fixes tag be >>> changed into the following? >>> Fixes: edd163687ea5 ("[SCSI] hpsa: add driver for HP >>> Smart Array controllers.") >> % git blame -L 5853,+1 -- drivers/scsi/hpsa.c >> b705690d8d16f7081 (Stephen M. Cameron 2012-01-19 14:00:53 >> -0600 5853) >> sh = scsi_host_alloc(&hpsa_driver_template, sizeof(h)); >> Is anything wrong here? > Yes, this commit just moves > sh = scsi_host_alloc(&hpsa_driver_template, sizeof(h)); > from one function to another one. > edd163687ea5 ("[SCSI] hpsa: add driver for HP Smart Array > controllers.") > is the correct commit introducing the bug. ACK. 2 BVA: please use the correct commit number. -- Alexey V. Vissarionov gremlin ПРИ altlinux ТЧК org; +vii-cmiii-ccxxix-lxxix-xlii GPG: 0D92F19E1C0DC36E27F61A29CD17E2B43D879005 @ hkp://keys.gnupg.net
Attachment:
signature.asc
Description: PGP signature