On Fri, Jul 27, 2007 at 10:39:06AM -0400, Jeff Garzik wrote: > Ancillary comments: > > 1) It is a common style to > > #define DRV_NAME "advansys" > > at the top, and then use DRV_NAME in request_region() calls, > request_irq() calls, struct eisa_driver, struct pci_driver, ... Yup. > 2) A future cleanup might add __FUNCTION__ to ASC_PRINTx, eliminating a > lot of manual reproduction of same Goodness, yes. Again, a can of worms I haven't had the heart to use the opener on yet. Also ASC_DBG needs to be turned into pr_debug. Thee's so much yuck in this driver, I've had a hard time staying focused on cleaning up only one thing at a time. Did you mention 'remove internal queueing' yet? If not, I beat you to it ;-) -- "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
