On 1/17/23 16:37, Christoph Hellwig wrote: > Is sysfs really the right interface here? I would have expected an > ioctl (and for kernel use method) on the block device to more > useful. Especially all the dynamic sysfs manipulation from a driver > is a little scary to me. I found it convenient to have everything in sysfs as everything is visible from the shell without needing any extra tooling. And I did that because I thought ioctls should not be added... We could add one though, but then I do not see much value since cdl-tools (cdladm utility) and sg3utils/sdparm can give that information already. -- Damien Le Moal Western Digital Research