Matthew Wilcox wrote:
+ goto exit;
+
+ kmalloc_failed:
+ ASC_PRINT1("advansys_wide_init_chip: board %d error: kmalloc() "
+ "failed\n", boardp->id);
+ err_code = ADV_ERROR;
+ exit:
+ return err_code;
+}
Regardless of the original code, it is quite irregular to force the
caller to clean up after advansys_wide_init_chip() kmalloc failure. I
could understand it, perhaps, if err_free_wide_mem label was used more
than once, but it's not.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
