Hi Bart >-----Original Message----- >From: Bart Van Assche [mailto:bvanassche@xxxxxxx] >Sent: Saturday, January 7, 2023 3:28 AM >To: Martin K . Petersen <martin.petersen@xxxxxxxxxx> >Cc: Jaegeuk Kim <jaegeuk@xxxxxxxxxx>; Avri Altman ><avri.altman@xxxxxxx>; Adrian Hunter <adrian.hunter@xxxxxxxxx>; linux- >scsi@xxxxxxxxxxxxxxx; Bart Van Assche <bvanassche@xxxxxxx>; Kiwoong Kim ><kwmad.kim@xxxxxxxxxxx>; James E.J. Bottomley <jejb@xxxxxxxxxxxxx>; >Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>; Chanho Park ><chanho61.park@xxxxxxxxxxx>; Alim Akhtar <alim.akhtar@xxxxxxxxxxx>; >Bean Huo <beanhuo@xxxxxxxxxx> >Subject: [PATCH 2/3] scsi: ufs: Exynos: Fix the maximum segment size > >Prepare for enabling DMA clustering and also for supporting PAGE_SIZE != >4096 by declaring explicitly that the maximum segment size is 4096 bytes for >Exynos UFS host controllers. > >Cc: Kiwoong Kim <kwmad.kim@xxxxxxxxxxx> >Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx> >--- Thanks! Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx> Tested on platforms containing Exynos HCI, so feel free to add Tested-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx> For some reason, I didn't receive you patch-3/3 in my inbox. > drivers/ufs/host/ufs-exynos.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > >diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c >index 3cdac89a28b8..821c000ca6b0 100644 >--- a/drivers/ufs/host/ufs-exynos.c >+++ b/drivers/ufs/host/ufs-exynos.c >@@ -1586,15 +1586,21 @@ static int exynos_ufs_probe(struct >platform_device *pdev) > const struct ufs_hba_variant_ops *vops = &ufs_hba_exynos_ops; > const struct exynos_ufs_drv_data *drv_data = > device_get_match_data(dev); >+ struct ufs_hba *hba; > > if (drv_data && drv_data->vops) > vops = drv_data->vops; > > err = ufshcd_pltfrm_init(pdev, vops); >- if (err) >+ if (err) { > dev_err(dev, "ufshcd_pltfrm_init() failed %d\n", err); >+ return err; >+ } >+ >+ hba = dev_get_drvdata(dev); >+ hba->host->max_segment_size = 4096; > >- return err; >+ return 0; > } > > static int exynos_ufs_remove(struct platform_device *pdev)
