On 2023-01-08 16:53:30, Lux Aliaga wrote: > Introduce Universal Flash Storage support on SM6125 and add support for the Xiaomi Mi A3 based on the former platform. Uses the name xiaomi-laurel-sprout instead of the official codename (laurel_sprout) Don't forget to wrap these lines properly, same for the changelog below. > due to naming limitations in the kernel. I doubt it's a limitation, more like a convention. > Changes since v5: > - Drop "non-removable" property from ufs_mem_hc for sm6125 platform > - Drop "status" and "autorepeat" properties from gpio-keys node for xiaomi-laurel-sprout > - Rename "key-vol-up" node to "key-volume-up" for xiaomi-laurel-sprout > - Drop "gpio-key,wakeup" property from key-volume-up node for xiaomi-laurel-sprout No, you /replaced/ this deprecated property with wakeup-source, which has the same meaning. > - Set "linux,input-type" and "wakeup-source" properties on key-volume-up node for xiaomi-laurel-sprout No, you /removed/ linux,input-type because its value 1 for EV_KEY is already the default. > - Change "key_vol_up" node name to "vol-up-n-state" and its label to "vol_up_n" in PM6125 GPIO node for xiaomi-laurel-sprout > - Use labels instead of node names for PM6125 ADC channels in xiaomi laurel-sprout > - Set "regulator-allow-set-load" properties on l4, l5, l10, l11, l18 and l24 regulators on xiaomi-laurel-sprout > > v5: https://lore.kernel.org/linux-devicetree/20221231222420.75233-2-they@xxxxxxxxx/ > > > No need for excessive newlines here. - Marijn
