On Dec 13, 2022 / 07:17, Shinichiro Kawasaki wrote: > Hello Sathya, thanks for the comment. > > On Dec 12, 2022 / 22:38, Sathya Prakash Veerichetty wrote: > > On Mon, Dec 12, 2022 at 5:52 PM Shin'ichiro Kawasaki [...] > > > alltgt_info = kzalloc(size, GFP_KERNEL); > > > if (!alltgt_info) > > > return -ENOMEM; > > > @@ -358,7 +365,7 @@ static long mpi3mr_get_all_tgt_info(struct mpi3mr_ioc *mrioc, > > > > > > sg_copy_from_buffer(job->request_payload.sg_list, > > > job->request_payload.sg_cnt, > > > - alltgt_info, job->request_payload.payload_len); > > > + alltgt_info, size); > > instead of size, this should be min_entry_len+sizeof(u32). > > Thanks for the comment. I read through mpi3mr_get_all_tgt_info() again. I still > have three unclear points. Your comments on them will be appreciated. I've posted v3 using min_entrylen as you suggested. Also I added two more patches to the series, based on my understanding on the three points I had noted. Your review will be appreciated. -- Shin'ichiro Kawasaki
