On 1/8/23 00:20, Avri Altman wrote:
All UFS host controllers support DMA clustering. Hence enable DMA clustering.
Note: without patch "Exynos: Fix the maximum segment size", this patch breaks
support for the Exynos controller.
Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
---
drivers/ufs/core/ufshcd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c index
be18edf4ef7f..fe83fdda8d23 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -8429,7 +8429,6 @@ static struct scsi_host_template
ufshcd_driver_template = {
.max_host_blocked = 1,
.track_queue_depth = 1,
.sdev_groups = ufshcd_driver_groups,
- .dma_boundary = PAGE_SIZE - 1,
>
Isn't DBC <= 256KB implies that for a boundary?
Hi Avri,
I don't think so. I think that the 256 KiB limit for the PRDT
corresponds to the max_segment_size parameter. The dma_boundary
parameter represents a boundary that must not be crossed by DMA
scatter/gather lists. I'm not aware of any restrictions on DMA
scatter/gather lists for UFS controllers other than the 256 KiB limit
for a single PRDT and a limitation to 32-bits addresses for controllers
that only support 32-bits DMA. The latter restriction is already handled
by ufshcd_set_dma_mask().
Bart.
