> On 12/22/22 02:21, Johan Hovold wrote: > > + /* Enable Write Booster if we have scaled up else disable it */ > > + if (ufshcd_enable_wb_if_scaling_up(hba)) > > + ufshcd_wb_toggle(hba, scale_up); > > Hi Asutosh, > > This patch is the second complaint about the mechanism that toggles the > WriteBooster during clock scaling. Can this mechanism be removed entirely? commit 87bd05016a64 that introduced UFSHCD_CAP_WB_WITH_CLK_SCALING enables the platform vendors and OEMs to maintain wb toggling - should they choose so. Why remove it in its entirety? Thanks, Avri > > I think this commit introduced that mechanism: 3d17b9b5ab11 ("scsi: ufs: > Add write booster feature support"; v5.8). > > Thanks, > > Bart.