From: ye xingchen <ye.xingchen@xxxxxxxxxx> Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: ye xingchen <ye.xingchen@xxxxxxxxxx> --- drivers/scsi/aacraid/linit.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c index 5ba5c18b77b4..83db3195cc1a 100644 --- a/drivers/scsi/aacraid/linit.c +++ b/drivers/scsi/aacraid/linit.c @@ -1233,21 +1233,17 @@ static ssize_t aac_show_flags(struct device *cdev, if (nblank(dprintk(x))) len = snprintf(buf, PAGE_SIZE, "dprintk\n"); #ifdef AAC_DETAILED_STATUS_INFO - len += scnprintf(buf + len, PAGE_SIZE - len, - "AAC_DETAILED_STATUS_INFO\n"); + len += sysfs_emit_at(buf, len, "AAC_DETAILED_STATUS_INFO\n"); #endif if (dev->raw_io_interface && dev->raw_io_64) - len += scnprintf(buf + len, PAGE_SIZE - len, - "SAI_READ_CAPACITY_16\n"); + len += sysfs_emit_at(buf, len, "SAI_READ_CAPACITY_16\n"); if (dev->jbod) - len += scnprintf(buf + len, PAGE_SIZE - len, - "SUPPORTED_JBOD\n"); + len += sysfs_emit_at(buf, len, "SUPPORTED_JBOD\n"); if (dev->supplement_adapter_info.supported_options2 & AAC_OPTION_POWER_MANAGEMENT) - len += scnprintf(buf + len, PAGE_SIZE - len, - "SUPPORTED_POWER_MANAGEMENT\n"); + len += sysfs_emit_at(buf, len, "SUPPORTED_POWER_MANAGEMENT\n"); if (dev->msi) - len += scnprintf(buf + len, PAGE_SIZE - len, "PCI_HAS_MSI\n"); + len += sysfs_emit_at(buf, len, "PCI_HAS_MSI\n"); return len; } -- 2.25.1