On 2022/12/07 11:36, Shin'ichiro Kawasaki wrote:
> When kconfig item CONFIG_SCSI_MPI3MR was introduced for mpi3mr driver,
> makefile of the driver was not modified to refer the kconfig item. Then
> mpi3mr.ko is built regardless of the kconfig item value y or m. Also
> "make localmodconfig" can not find the kconfig item in the makefile,
> then it does not generate CONFIG_SCSI_MPI3MR=m even when mpi3mr.ko is
> loaded on the system. Refer the kconfig item to avoid the issues.
>
> Fixes: c4f7ac64616e ("scsi: mpi3mr: Add mpi30 Rev-R headers and Kconfig")
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx>
> ---
> drivers/scsi/mpi3mr/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/mpi3mr/Makefile b/drivers/scsi/mpi3mr/Makefile
> index ef86ca46646b..3bf8cf34e1c3 100644
> --- a/drivers/scsi/mpi3mr/Makefile
> +++ b/drivers/scsi/mpi3mr/Makefile
> @@ -1,5 +1,5 @@
> # mpi3mr makefile
> -obj-m += mpi3mr.o
> +obj-$(CONFIG_SCSI_MPI3MR) += mpi3mr.o
> mpi3mr-y += mpi3mr_os.o \
> mpi3mr_fw.o \
> mpi3mr_app.o \
Looks good to me.
Reviewed-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>
--
Damien Le Moal
Western Digital Research
