Re: [PATCH v4 18/23] scsi: ufs: core: Add reinit_notify() callback

Bart Van Assche <bvanassche@xxxxxxx> · Thu, 1 Dec 2022 10:05:57 -0800

On 12/1/22 09:43, Manivannan Sadhasivam wrote:
reinit_notify() callback can be used by the UFS controllers to perform
changes required for UFS core reinit.

What does "UFS core" refer to in this context? Should "UFS core" perhaps 
be changed into "UFS controller phy"?

diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h
index 5cf81dff60aa..af8c95077d96 100644
--- a/include/ufs/ufshcd.h
+++ b/include/ufs/ufshcd.h
@@ -297,6 +297,7 @@ struct ufs_pwr_mode_info {
   * @config_scaling_param: called to configure clock scaling parameters
   * @program_key: program or evict an inline encryption key
   * @event_notify: called to notify important events
+ * @reinit_notify: called to notify UFS core reinit

Please make this comment more clear. Nobody knows what "UFS core" means.

Thanks,

Bart.







