On Wed, 23 Nov 2022 20:21:35 +0800, Wenchao Hao wrote: > Following scenario would make scsi_device's iodone_cnt mismatch with > iorequest_cnt even if there is no request on this device any more. > > 1. request timeout happened. If we do not retry the timeouted command, > this command would be finished in scsi_finish_command() which would > not increase the iodone_cnt; if the timeouted command is retried, > another increasement for iorequest_cnt would be performed, the > command might add iorequest_cnt for multiple times but iodone_cnt > only once. Increase iodone_cnt in scsi_timeout() can handle this > scenario. > > [...] Applied to 6.2/scsi-queue, thanks! [1/2] scsi: increase scsi device's iodone_cnt in scsi_timeout() https://git.kernel.org/mkp/scsi/c/ec9780e48c77 [2/2] scsi: donot increase scsi_device's iorequest_cnt if dispatch failed https://git.kernel.org/mkp/scsi/c/cfee29ffb45b -- Martin K. Petersen Oracle Linux Engineering