On Tue, Nov 29, 2022 at 10:58:09PM -0800, Johannes Thumshirn wrote: > +++ b/drivers/scsi/sd_zbc.c > @@ -18,6 +18,11 @@ > #include <scsi/scsi.h> > #include <scsi/scsi_cmnd.h> > > +#if IS_MODULE(CONFIG_BLK_DEV_SD) > +#define CREATE_TRACE_POINTS > +#endif > +#include <trace/events/scsi.h> Urg, this will create duplicates of all the tracepoints if sd is built modular. Can't we just have a separate b/drivers/scsi/sd_trace.h for sd-specific tracepoints? If not, we'll just need to EXPORT_TRACEPOINT_SYMBOL_GPL the tracepoints used in sd.
