On Thu, Nov 24, 2022 at 1:29 AM Mike Christie <michael.christie@xxxxxxxxxx> wrote: > > On 11/22/22 10:41 PM, Wenchao Hao wrote: > > Sorry I did not highlight the key points. The root reason we need to record > > node_startup mode in kernel is userspace's node_startup mode is unreliable in > > some scenarios: > > > > 1. iscsi node and session is created in initrd, the configure files of these > > nodes would be lost after we switch to rootfs > > 2. someone do iscsiadm -m discovery but did not specify the operation mode, > > the iscsi node's node_startup would be updated to which specified in iscsid.conf > > 3. someone do iscsiadm -m node -o update to update nodes' configure > > > > What's more, it seems "iscsiadm/iscsid" only refuse to logout of an ONBOOT > > session when logout is specificed by "--logoutall". We still can logout an > > ONBOOT session with "iscsiadm -m node -u comamnd". > > logout_by_startup does go by the startup setting, but I think you missed the > session_in_use related code. It checks the mounts and holders already. Just > change it for whatever you need. I think your lvm use case should be covered > by the holder check. If not, add it. I did not enable the iscsid.safe_logout in iscsid.conf, so the session still could be logged out. If tested with iscsid.safe_logout set to "Yes", the issue is solved. Thanks a lot
