From: "Moore, Eric" <Eric.Moore@xxxxxxx> Subject: RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg Date: Tue, 24 Jul 2007 18:22:08 -0600 > > > I'm not sure what the intent of this else case. > > > > This code is for an "invisible" SMP target in LSI SAS HBAs. There are > > better ways to get the target's address, I think. Any suggestions? > > > > I've never heard that we(as in LSI) are attaching invisable SMP targets > to HBA's. I've seen the Virtual SMP Port, but those are not hidden, the > driver would report them to the transport layer, therefore rphy should > be non-zero. For instance a 12 phy expander would have 13 phys(with > the last being the virtual phy). I doubt we need to have this else > case in the code, as it will be returning the sas_address to the first > attached device(which may not always be an expander). Are you > executing the else path? In the else path, I try to get the virtual phy's address. That is, I try to do what sas_low_phy_scandir_select() in Doug's lsscsi tool does. - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
