Re: [PATCH v2] scsi: target: tcm_loop: fix possible name leak in tcm_loop_setup_hba_bus()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/14/22 7:50 PM, Yang Yingliang wrote:
> If device_register() fails in tcm_loop_setup_hba_bus(), the name allocated
> by dev_set_name() need be freed. As comment of device_register() says, it
> should use put_device() to give up the reference in the error path. So fix
> this by calling put_device(), then the name can be freed in kobject_cleanup().
> The 'tl_hba' will be freed in tcm_loop_release_adapter(), so it don't need
> goto error label in this case.
> 
> Fixes: 3703b2c5d041 ("[SCSI] tcm_loop: Add multi-fabric Linux/SCSI LLD fabric module")
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> ---
> v1 -> v2:
>   Move put_device() in tcm_loop_setup_hba_bus().
> ---

Reviewed-by: Mike Christie <michael.chritie@xxxxxxxxxx>




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux