Re: [PATCH] scsi: mpi3mr: suppress command reply debug prints

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Nov 10, 2022 / 13:22, Sathya Prakash Veerichetty wrote:
> On Tue, Nov 8, 2022 at 10:22 PM Damien Le Moal
> <damien.lemoal@xxxxxxxxxxxxxxxxxx> wrote:
> >
> > On 11/9/22 12:12, Shin'ichiro Kawasaki wrote:

...

> > > diff --git a/drivers/scsi/mpi3mr/mpi3mr_os.c b/drivers/scsi/mpi3mr/mpi3mr_os.c
> > > index f77ee4051b00..2b95d1d375f2 100644
> > > --- a/drivers/scsi/mpi3mr/mpi3mr_os.c
> > > +++ b/drivers/scsi/mpi3mr/mpi3mr_os.c
> > > @@ -3265,7 +3265,8 @@ void mpi3mr_process_op_reply_desc(struct mpi3mr_ioc *mrioc,
> > >       }
> > >
> > >       if (scmd->result != (DID_OK << 16) && (scmd->cmnd[0] != ATA_12) &&
> > > -         (scmd->cmnd[0] != ATA_16)) {
> > > +         (scmd->cmnd[0] != ATA_16) &&
> > > +         mrioc->logging_level & MPI3_DEBUG_REPLY) {
> 
> >>> Thanks for fixing this, Can you please use MPI3_DEBUG_SCSI_ERROR instead of MPI3_DEBUG_REPLY as that makes more sense.

Thanks for the comment. Will do so.

-- 
Shin'ichiro Kawasaki



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux